RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v2]

[Daniel Lundén]

On Tue, 29 Apr 2025 11:56:25 GMT, Hendrik Schick <duke at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates after reviews
>
> src/hotspot/share/opto/gcm.cpp line 674:
> 
>> 672: //
>> 673: //   1. raise the load's LCA to force the load to (eventually) be scheduled at
>> 674: //      latest in the stores's block, and
> 
> Suggestion:
> 
> //      latest in the store's block, and

Thanks, fixed!

> src/hotspot/share/opto/gcm.cpp line 682:
> 
>> 680: // path relative to the load if there are no paths from early to LCA that go
>> 681: // through the store's block. Such stores are not anti-dependent, and there is
>> 682: // no need to update the LCA nor to add anti-depencence edges.
> 
> Suggestion:
> 
> // no need to update the LCA nor to add anti-dependence edges.

Thanks, fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2068372597
PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2068372685