RFR: 8355704: RISC-V: enable TestIRFma.java

Hamlin Li mli at openjdk.org
Wed Apr 30 14:45:49 UTC 2025


On Wed, 30 Apr 2025 11:51:55 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch to enable TestIRFma.java?
>> FmaF/D (checked by TestIRFma.java) are supported on riscv, but for some reason we can not enable it easily, but we should enable it.
>> 
>> NOTE: the reason I change IRNode matching rules is that, previously it verify the `FINAL CODE` where every platform could have different instruct name; I change it from machOnlyNameRegex to beforeMatchingNameRegex, to make it verify the `PrintIdeal` where every platform share the same names.
>> 
>> Also tested on machine with `asimd` support.
>> 
>> Thanks!
>
> test/hotspot/jtreg/compiler/c2/irTests/TestIRFma.java line 89:
> 
>> 87: 
>> 88:     @Test
>> 89:     @IR(counts = {IRNode.FMSUB_F, "> 0", IRNode.NEG_F, "> 0"},
> 
> What is the reason for adding the "IRNode.NEG_F" ?

I think I need to reconsider the test improvement, will update the pr later.

Thank for having a look.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24947#discussion_r2068814573


More information about the hotspot-compiler-dev mailing list