RFR: 8354520: IGV: dump contextual information [v5]

[Emanuel Peter]

On Wed, 30 Apr 2025 14:39:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Document workaround for lldb issue
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 967:
> 
>> 965:   if (!_current_method || !_should_send_method || node == nullptr) return;
>> 966: 
>> 967:   frame current = fr == nullptr ? os::current_frame() : *fr;
> 
> Suggestion:
> 
>   frame current_frame = fr == nullptr ? os::current_frame() : *fr;
> 
> Just to make sure there is no confusion with `_current_method`.
> Optional, up to you.

Also: what is the implication of having the `frame` object on the stack, rather than a pointer to it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24724#discussion_r2068812834