RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v50]
Emanuel Peter
epeter at openjdk.org
Wed Apr 30 15:40:08 UTC 2025
On Tue, 22 Apr 2025 17:01:48 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi,
>>
>> This patch adds unsigned bounds and known bits constraints to TypeInt and TypeLong. This opens more transformation opportunities in an elegant manner as well as helps avoid some ad-hoc rules in Hotspot.
>>
>> In general, a `TypeInt/Long` represents a set of values `x` that satisfies: `x s>= lo && x s<= hi && x u>= ulo && x u<= uhi && (x & zeros) == 0 && (x & ones) == ones`. These constraints are not independent, e.g. an int that lies in [0, 3] in signed domain must also lie in [0, 3] in unsigned domain and have all bits but the last 2 being unset. As a result, we must canonicalize the constraints (tighten the constraints so that they are optimal) before constructing a `TypeInt/Long` instance.
>>
>> This is extracted from #15440 , node value transformations are left for later PRs. I have also added unit tests to verify the soundness of constraint normalization.
>>
>> Please kindly review, thanks a lot.
>>
>> Testing
>>
>> - [x] GHA
>> - [x] Linux x64, tier 1-4
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>
> more rigour for ~hi
I had a quick look at some of our conversations, and responded in these:
https://github.com/openjdk/jdk/pull/17508/files#r2068879473
https://github.com/openjdk/jdk/pull/17508/files#r2068924501
https://github.com/openjdk/jdk/pull/17508/files#r2068935771
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2842405700
More information about the hotspot-compiler-dev
mailing list