RFR: 8324751: C2 SuperWord: Aliasing Analysis runtime check [v3]

[Emanuel Peter]

On Mon, 28 Jul 2025 11:27:05 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/compiler/loopopts/superword/TestAliasingFuzzer.java
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - Update src/hotspot/share/opto/vectorization.hpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - Update src/hotspot/share/opto/vtransform.hpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - some suggestions by Manuel
>
> src/hotspot/share/opto/mempointer.cpp line 732:
> 
>> 730: //   -> Unknown if overlap at runtime -> return false
>> 731: bool MemPointer::always_overlaps_with(const MemPointer& other) const {
>> 732:   const MemPointerAliasing aliasing = get_aliasing_with(other NOT_PRODUCT( COMMA _trace ));
> 
> Suggestion:
> 
>   const MemPointerAliasing aliasing = get_aliasing_with(other NOT_PRODUCT(COMMA _trace));
> 
> Nit: You used this without spaces already above.

To be honest: I've used `NOT_PRODUCT` quite inconsistently here. The most closely matching is the use in `MemPointer::never_overlaps_with`, where I am using spaces. So I'll leave it analogous to that ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24278#discussion_r2249629811