RFR: 8364618: Sort share/code includes
Francesco Andreuzzi
duke at openjdk.org
Mon Aug 4 10:09:56 UTC 2025
On Mon, 4 Aug 2025 10:04:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> This PR sorts the includes in `hotspot/share/code` using `SortIncludes.java`. I'm also adding the directory to `TestIncludesAreSorted`.
>>
>> Passes tier1.
>
> src/hotspot/share/code/aotCodeCache.cpp line 60:
>
>> 58: #include "gc/z/zBarrierSetRuntime.hpp"
>> 59: #endif
>> 60: #ifdef COMPILER2
>
> This one looks weird. This splits `#ifdef COMPILER1` and `#ifdef COMPILER2` blocks.
> Was that the automatic move, or have you moved it yourself?
I did it myself, so the conditionally included modules are sorted alphabetically. Should I revert it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26616#discussion_r2251020668
More information about the hotspot-compiler-dev
mailing list