RFR: 8364618: Sort share/code includes [v2]
Francesco Andreuzzi
duke at openjdk.org
Mon Aug 4 10:35:25 UTC 2025
On Mon, 4 Aug 2025 10:17:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> I did it myself, so the conditionally included modules are sorted alphabetically. Should I revert it?
>
> Yes, revert this hunk. The GC blocks are somewhat odd (notice the difference between `#if` and `#ifdef`), and I think the common style is to include them the last. Not that it is codified anywhere, AFAICS.
c441715908e0c3f84016faa232ad8afbab89a972
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26616#discussion_r2251072742
More information about the hotspot-compiler-dev
mailing list