RFR: 8325482: Test that distinct seeds produce distinct traces for compiler stress flags [v2]
Saranya Natarajan
snatarajan at openjdk.org
Mon Aug 4 12:44:22 UTC 2025
On Mon, 4 Aug 2025 08:14:28 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Saranya Natarajan has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - changing N to 5
>> - Adding test for same seed --> same result for N = 10
>
> test/hotspot/jtreg/compiler/debug/TestStressDistinctSeed.java line 99:
>
>> 97: if (args.length == 0) {
>> 98: for (int s = 0; s < 5; s++) {
>> 99: igvntrace = igvnTrace(s);
>
> Did you choose the 0-4 seeds to be sure that there are at least a couple of different traces? I guess it wouldn't be so easy to exclude that with random values, right?
Thank you for the review.
This comes from [test/hotspot/jtreg/compiler/debug/TestStressDistinctSeed.java](https://github.com/openjdk/jdk/pull/26554/files/14617e01a032fe05775eda36f4f3172137ccd2e8#diff-abc400ea5cb08b3f662a32173c0ee2d15306f51d1e8930bd295ab7c2d2b52980) and my reasoning is same as what you mentioned above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26554#discussion_r2251370113
More information about the hotspot-compiler-dev
mailing list