RFR: 8364141: Remove LockingMode related code from x86 [v2]

Fredrik Bredberg fbredberg at openjdk.org
Tue Aug 5 12:16:08 UTC 2025


On Tue, 5 Aug 2025 06:25:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update one after review
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 1034:
> 
>> 1032: 
>> 1033:   // Load object pointer into obj_reg
>> 1034:   movptr(obj_reg, Address(lock_reg, BasicObjectLock::obj_offset()));
> 
> Do you not still need the `in_bytes()` around `obj_offset()`?

I don't think so. Or at least there are lots of examples that seems to do just fine without `in_bytes()` around `obj_offset()`, like [this line](https://github.com/openjdk/jdk/blob/2a0521863ba7d9df9b4039e61b2ce6932960cd22/src/hotspot/cpu/x86/interp_masm_x86.cpp#L1073).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26552#discussion_r2254163684


More information about the hotspot-compiler-dev mailing list