RFR: 8364141: Remove LockingMode related code from x86 [v2]

Fredrik Bredberg fbredberg at openjdk.org
Tue Aug 5 12:23:04 UTC 2025


On Tue, 5 Aug 2025 06:14:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update one after review
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 392:
> 
>> 390: // Some commentary on balanced locking:
>> 391: //
>> 392: // fast_lock and fast_unlock are emitted only for provably balanced lock sites.
> 
> I assume this is also correct for `lightweight_lock` and `lightweight_unlock`?

I assume the same. But I don't want to change the comments too much, since I plan to do a clean up in which all "lightweight" prefixes will be gone and we will begin talking about it as the normal locking mode. And no, I will not just rename it `normal_lock()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26552#discussion_r2254178104


More information about the hotspot-compiler-dev mailing list