RFR: 8358598: PhaseIterGVN::PhaseIterGVN(PhaseGVN* gvn) doesn't use its parameter

Manuel Hässig mhaessig at openjdk.org
Tue Aug 5 13:46:06 UTC 2025


On Mon, 4 Aug 2025 09:47:23 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

> As noted in the ticket, I propose a small cleanup of `PhaseIterGVN` since one of the constructors does not use its parameter.
> 
> Passes tier1 and tier2.

Thank you for working on this cleanup, @fandreuz! The changes look good to me. I only have one nit.

I also kicked off testing on our side and will keep you posted on the results.

src/hotspot/share/opto/phaseX.cpp line 812:

> 810: // Initialize from scratch
> 811: PhaseIterGVN::PhaseIterGVN() : _delay_transform(false),
> 812:                               _worklist(*C->igvn_worklist())

Suggestion:

PhaseIterGVN::PhaseIterGVN() : _delay_transform(false),
                               _worklist(*C->igvn_worklist())

Nit: align with line above

-------------

Changes requested by mhaessig (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26617#pullrequestreview-3088340502
PR Review Comment: https://git.openjdk.org/jdk/pull/26617#discussion_r2254382103


More information about the hotspot-compiler-dev mailing list