RFR: 8360192: C2: Make the type of count leading/trailing zero nodes more precise [v3]
Qizheng Xing
qxing at openjdk.org
Wed Aug 6 06:12:03 UTC 2025
On Mon, 4 Aug 2025 16:49:02 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
>> When someone passes a non-integer to `CountLeadingZerosINode`, I think.
>
> Since the function filters `Type::TOP` earlier, I don't think it is possible to see non-int types here. I think it would be better to change it to `is_int()` and remove the null check, so that any broken graph constructions can be caught with the assert on the type check. You might also need to check for `Type::BOTTOM`.
@jaskarth Thanks for review, I've updated this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25928#discussion_r2255956549
More information about the hotspot-compiler-dev
mailing list