RFR: 8361582: AArch64: Some ConH values cannot be replicated with SVE [v3]

[Bhavana Kilambi]

On Thu, 7 Aug 2025 13:54:39 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 52:
> 
>> 50: 
>> 51:    // Choose FP16_CONST1 which is within the range of [-128 << 8, 127 << 8] and a multiple of 256
>> 52:     private static final Float16 FP16_CONST1 = Float16.shortBitsToFloat16((short)512);
> 
> Call them `FP16_IN_RANGE` and `FP16_OUT_OF_RANGE`, maybe? Also rename the test cases from `*1`/`*2` to `*InRange`/`*OutOfRange`?

Done

> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 68:
> 
>> 66: 
>> 67:         Generator<Short> gen = G.float16s();
>> 68:         IntStream.range(0, LEN).forEach(i -> {input[i] = gen.next();});
> 
> Just do a for loop?

Done

> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 79:
> 
>> 77:     @IR(counts = {IRNode.REPLICATE_HF_IMM8, ">0"},
>> 78:         phase = CompilePhase.FINAL_CODE,
>> 79:         applyIf = {"MaxVectorSize", ">=32"},
> 
> `> 16` then? This matches the comment better.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2265940398
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2265940614
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2265940903