RFR: 8358696: Assert with extreme values for -XX:BciProfileWidth [v6]

[Saranya Natarajan]

On Mon, 11 Aug 2025 01:38:55 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing review - testcase and max range is set to 1000
>
> test/hotspot/jtreg/compiler/arguments/TestBciProfileWidth.java line 28:
> 
>> 26:  * @summary Test the range defined in globals.hpp for BciProfileWidth
>> 27:  * @bug 8358696
>> 28:  * @run main/othervm -XX:BciProfileWidth=0
> 
> `BciProfileWidth` is debug only, right?

Thank you for the review. 
I have now included `@requires vm.debug`

> test/lib-test/jdk/test/whitebox/vm_flags/IntxTest.java line 41:
> 
>> 39:     private static final long COMPILE_THRESHOLD = VmFlagTest.WHITE_BOX.getIntxVMFlag("CompileThreshold");
>> 40:     private static final Long[] TESTS = {0L, 100L, (long)(Integer.MAX_VALUE>>3)*100L};
>> 41:     private static final String FLAG_DEBUG_NAME = "BinarySwitchThreshold";
> 
> Why did you move the location of the declaration?

This was an oversight. I have moved to where it was declared previously

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2266378826
PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2266384171