RFR: 8356176: C2 MemorySegment: missing RCE with byteSize() in Loop Exit Check inside the for Expression [v2]

Manuel Hässig mhaessig at openjdk.org
Tue Aug 12 09:34:37 UTC 2025


On Mon, 11 Aug 2025 15:43:05 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix debug print
>>  - Test more flags
>>  - Renaming and comments
>
> src/hotspot/share/opto/loopnode.hpp line 1639:
> 
>> 1637:     // Sum of all wins regardless of where they happen.
>> 1638:     int _total_wins;
>> 1639:     // Number of wins on a loop entry edge, which only pays dividens once per loop execution.
> 
> You should specify that "If the split is through a loop head", otherwise `0`. Also, typo `dividends`

I tried my hand at an improvement. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26429#discussion_r2269266215


More information about the hotspot-compiler-dev mailing list