RFR: 8324751: C2 SuperWord: Aliasing Analysis runtime check [v6]
Emanuel Peter
epeter at openjdk.org
Tue Aug 12 15:52:19 UTC 2025
On Mon, 11 Aug 2025 12:28:31 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test/hotspot/jtreg/compiler/loopopts/superword/TestAliasingFuzzer.java
>>
>> Co-authored-by: Manuel Hässig <manuel at haessig.org>
>
> src/hotspot/share/opto/vectorization.cpp line 1026:
>
>> 1024: if (vp1.iv_scale() > vp2.iv_scale()) {
>> 1025: swap(p1_init, p2_init);
>> 1026: swap(size1, size2);
>
> Shouldn't we perform this swap before calling `make_last()`, since `make_last()` assumes `iv_scale1 < iv_scale2`?
I don't think that `make_last` makes any assumptions about `iv_scale1 < iv_scale2`.
But I could consider moving it earlier anyway. Do you think that is worth it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24278#discussion_r2270365536
More information about the hotspot-compiler-dev
mailing list