RFR: 8361582: AArch64: Some ConH values cannot be replicated with SVE [v4]
Bhavana Kilambi
bkilambi at openjdk.org
Wed Aug 13 10:23:18 UTC 2025
On Mon, 11 Aug 2025 09:11:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed review comments and modified some comments
>
> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 45:
>
>> 43: public class TestFloat16Replicate {
>> 44: private static short[] input;
>> 45: private static short[] output;
>
> This might give things even more chance to vectorize? Not sure, feel free to ignore.
>
> Suggestion:
>
> private static final short[] INPUTE;
> private static final short[] OUTPUT;
I hope it's ok to not add these changes to the code. The loops are getting vectorized fine and the tests do pass on aarch64 and x86. I will consider this if there's any issue with auto vectorization in the futurre. Thanks
> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 47:
>
>> 45: private static short[] output;
>> 46:
>> 47: // Choose FP16_IN_RANGE which is within the range of [-128 << 8, 127 << 8] and a multiple of 256
>
> Suggestion:
>
> // Choose FP16_IN_RANGE which is within the range of [-128 << 8, 127 << 8] and a multiple of 256
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2272848883
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2272845319
More information about the hotspot-compiler-dev
mailing list