RFR: 8365262: [IR-Framework] Add simple way to add cross-product of flags

Manuel Hässig mhaessig at openjdk.org
Thu Aug 14 13:24:23 UTC 2025


On Thu, 14 Aug 2025 12:41:46 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> This PR adds the `TestFramework::addCrossProductScenarios` method to enable more ergonomic testing of the combination of all flag combinations. To illustrate its use, I also converted one test to use the new cross product functionality.
>> 
>> Testing:
>>  - [x] Github Actions
>>  - [x] tier1,tier2 plus some internal testing on Oracle supported platforms
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java line 49:
> 
>> 47:                                                "-XX:TLABRefillWasteFraction=64"));
>> 48:             t1.start();
>> 49:             Asserts.fail("Should have thrown exception");
> 
> Hmmm, why do the tests fail? I'm wondering if a simpler way to test the functionality is possible that doesn't require having to figure out failure modes? Maybe some kind of positive test that counts number of test scenarios run?

Except in the first run, all scenarios fail. That is the only way we currently have to count the scenarios we are executing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26762#discussion_r2276622808


More information about the hotspot-compiler-dev mailing list