RFR: 8364970: Redo JDK-8327381 by updating the CmpU type instead of the Bool type [v4]

Francisco Ferrari Bihurriet fferrari at openjdk.org
Thu Aug 14 18:35:54 UTC 2025


On Thu, 14 Aug 2025 18:23:24 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make testCorrectness @Run the C2 compiled versions
>>   
>>   Correctness of the tests with the following name format should be
>>   checked in the TestFramework.run() JVM process, with the C2 compiled
>>   version of these methods. TestFramework's warmup ensures this.
>>   
>>   testCase(1a|1b)(OptimizeAsTrue|OptimizeAsFalse)For(EQ|NE|LE|GE|LT|GT)(xm|mx)
>
> src/hotspot/share/opto/subnode.cpp line 902:
> 
>> 900:       const TypeInt* rhs_m_type = phase->type(rhs_m)->isa_int();
>> 901:       // Exclude any case where m == -1 is possible.
>> 902:       if (rhs_m_type != nullptr && (rhs_m_type->_lo > -1 || rhs_m_type->_hi < -1)) {
> 
> Please use `!rhs_m_type->contains(-1)`

Accepted in 25aa9d7e27a74cf6ed917af2d328f5880fe84de5. Simple smoke-test check: builds and the IR test passes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26666#discussion_r2277433703


More information about the hotspot-compiler-dev mailing list