RFR: 8324751: C2 SuperWord: Aliasing Analysis runtime check [v11]
Emanuel Peter
epeter at openjdk.org
Tue Aug 19 05:53:51 UTC 2025
On Mon, 18 Aug 2025 14:38:18 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> It is now used in the JMH benchmark, I'd have to remove it there too:
>> https://github.com/openjdk/jdk/pull/24278/files#diff-93288fabe20d76b9df3fb5601e4d8600a46f438fe4b9c4ef92d702fdffa1c8c9R225-R230
>
> It is not about diagnostic vs develop. It is about to keep it or not.
>
> It is fine to have this during development of these changes to prove that we need to optimize slow loops too.
> But now we know that we need to do the optimization. The only reason is to keep it is for debugging some future failures. You can keep it if you think it is very useful for debugging.
>
> My main concern is we have too many flags we never use and we are adding more.
It really is only for benchmarking. Probably not super useful for debugging. I'll remove it with all its uses.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24278#discussion_r2284140917
More information about the hotspot-compiler-dev
mailing list