RFR: 8358756: [s390x] Test StartupOutput.java crash due to CodeCache size [v2]
Lutz Schmidt
lucy at openjdk.org
Tue Aug 19 11:17:41 UTC 2025
On Tue, 17 Jun 2025 05:40:14 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> There isn't enough initial cache present which can let the interpreter mode run freely. So before even we reach to the compiler phase and try to bail out, in case there isn't enough space left for the stub compilation, JVM crashes. Idea is to increase the Initial cache size and make it enough to run interpreter mode at least.
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into testfix
> - take the platform change out of loop
> - fix
Changes requested by lucy (Reviewer).
test/hotspot/jtreg/compiler/startup/StartupOutput.java line 64:
> 62: }
> 63:
> 64: int minInitialSize = 800 + (Platform.isS390x() ? 800 : 0);
Do you unconditionally need the extra space or maybe only for fast debug builds?
Maybe add a comment on which initialization code sizes (interpreter, stubs, ...) you observe.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25741#pullrequestreview-3131849845
PR Review Comment: https://git.openjdk.org/jdk/pull/25741#discussion_r2284925309
More information about the hotspot-compiler-dev
mailing list