RFR: 8365829: Multiple definitions of static 'phase_names' [v2]
Francesco Andreuzzi
duke at openjdk.org
Wed Aug 20 08:21:58 UTC 2025
On Wed, 20 Aug 2025 01:55:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with seven additional commits since the last revision:
>>
>> - static
>> - nn
>> - indent
>> - review sugg
>> - revert
>> - Merge branch 'resolved-default-cctor' into JDK-8365829
>> - use copy ctor
>
> src/hotspot/share/compiler/compilerEvent.cpp line 61:
>
>> 59: namespace {
>> 60: GrowableArray<const char*>* phase_names = nullptr;
>> 61: }
>
> Don't use anonymous namespaces. See Style Guide.
Reverted in e7122cd679682d4550c5c1b18949a1d072e440df
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26851#discussion_r2287371820
More information about the hotspot-compiler-dev
mailing list