RFR: 8365829: Multiple definitions of static 'phase_names' [v2]

Stefan Karlsson stefank at openjdk.org
Wed Aug 20 14:08:44 UTC 2025


On Wed, 20 Aug 2025 13:16:07 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with seven additional commits since the last revision:
>> 
>>  - static
>>  - nn
>>  - indent
>>  - review sugg
>>  - revert
>>  - Merge branch 'resolved-default-cctor' into JDK-8365829
>>  - use copy ctor
>
> src/hotspot/share/opto/phasetype.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2017, 2025, Oracle and/or its affiliates. All rights reserved.
> 
> This is a new file, so I think "2017," shouldn't be here.

The guidelines that we follow is that if you copy code from another file to a new file you should use the old copyright years. So, using `2017, 2025,` seems correct to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26851#discussion_r2288293870


More information about the hotspot-compiler-dev mailing list