RFR: 8365829: Multiple definitions of static 'phase_names' [v2]
Francesco Andreuzzi
duke at openjdk.org
Wed Aug 20 14:27:25 UTC 2025
On Wed, 20 Aug 2025 13:18:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with seven additional commits since the last revision:
>>
>> - static
>> - nn
>> - indent
>> - review sugg
>> - revert
>> - Merge branch 'resolved-default-cctor' into JDK-8365829
>> - use copy ctor
>
> src/hotspot/share/opto/phasetype.hpp line 143:
>
>> 141: class CompilerPhaseTypeHelper {
>> 142: public:
>> 143: static const char* phase_descriptions[];
>
> Make these `static const char* const` ? Both here and for the definitions of course. I don't
> think there's any reason for the arrays to be mutable.
Sure: a66abc051fe6f640930cbcca9ab8240b6ca97aeb
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26851#discussion_r2288355536
More information about the hotspot-compiler-dev
mailing list