RFR: 8358696: Assert with extreme values for -XX:BciProfileWidth [v10]

Martin Doerr mdoerr at openjdk.org
Wed Aug 20 15:32:47 UTC 2025


On Wed, 20 Aug 2025 12:17:26 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - addressing review : nit comments
>>  - review : change to test case to test values outside the range
>
> test/lib-test/jdk/test/whitebox/vm_flags/IntxTest.java line 42:
> 
>> 40:     private static final long COMPILE_THRESHOLD = VmFlagTest.WHITE_BOX.getIntxVMFlag("CompileThreshold");
>> 41:     private static final Long[] TESTS = {0L, 100L, (long)(Integer.MAX_VALUE>>3)*100L};
>> 42: 
> 
> This empty line should not be removed.

Thanks! But, the indentation of the next line looks odd, now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26139#discussion_r2288545780


More information about the hotspot-compiler-dev mailing list