RFR: 8361582: AArch64: Some ConH values cannot be replicated with SVE [v7]
Emanuel Peter
epeter at openjdk.org
Thu Aug 21 06:05:58 UTC 2025
On Thu, 21 Aug 2025 05:59:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> I can test this on x86 but do you think this test is required to be placed out of `aarch64` folder and make it available for all architectures when the same pattern is already being tested in the above testcase for all architectures?
>
> If it is just about checking backend mach nodes with an IR rule, then why not just add the IR rule to the existing test?
After all it was with that test that we hit the assert, right?
$ CONF=linux-aarch64-server-fastdebug make images test TEST=compiler/vectorization/TestFloat16VectorOperations.java
#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/home/shipilev/shipilev-jdk/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:3756), pid=6237, tid=6259
# guarantee(false) failed: invalid immediate
My opinion:
- If it is exactly the same test -> keep it in the existing one.
- If your tests have a different shape -> make it available to all other platforms, to check at least for correctness
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2289939268
More information about the hotspot-compiler-dev
mailing list