RFR: 8361582: AArch64: Some ConH values cannot be replicated with SVE [v7]
Bhavana Kilambi
bkilambi at openjdk.org
Thu Aug 21 08:14:57 UTC 2025
On Thu, 21 Aug 2025 07:52:03 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed review comments
>
> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 66:
>
>> 64: input[i] = (short) i;
>> 65: }
>> 66: }
>
> How about using Generators for initialization?
That's what I had in my first patch but changed it to a `for` loop after this comment - https://github.com/openjdk/jdk/pull/26589#discussion_r2260403263.
I think it doesn't matter in this case. What's more important is the constant value being passed. Otherwise, the `TestFloat16VectorOperations.java` JTREG test does use generators and test this shape for all values of Float16.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2290263805
More information about the hotspot-compiler-dev
mailing list