RFR: 8365256: RelocIterator should use indexes instead of pointers [v2]

Johan Sjölen jsjolen at openjdk.org
Fri Aug 22 08:56:55 UTC 2025


On Wed, 20 Aug 2025 20:04:13 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Good catch by Vladimir
>>  - Vladimir's comments
>
> src/hotspot/share/code/relocInfo.hpp line 606:
> 
>> 604:   RelocIterator(CodeSection* cb, address begin = nullptr, address limit = nullptr);
>> 605:   RelocIterator(CodeBlob* cb);
>> 606:   RelocIterator(relocInfo& ri);
> 
> How about making this new ctor private?

We could do that, as both `Relocation` (the user of the ctr) and `RelocIterator` are friends.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26569#discussion_r2293130843


More information about the hotspot-compiler-dev mailing list