RFR: 8365909: [REDO] Add a compilation timeout flag to catch long running compilations
Manuel Hässig
mhaessig at openjdk.org
Fri Aug 22 09:49:51 UTC 2025
On Thu, 21 Aug 2025 11:56:17 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> This PR adds a timeout for compilation tasks based on timer signals on Linux debug builds.
>
> This PR is a redo of #25872 with fixes for the failing test.
>
> Testing:
> - [x] Github Actions
> - [x] tier1,tier2 plus internal testing on all Oracle supproted platforms
> - [x] tier3,tier4 on linux-x64-debug
> - [x] tier1,tier2,tier3,tier4 on linux-x64-debug with `-XX:CompileTaskTimeout=60000`
I originally ran `java -version` and checked that the string "java version" appeared in the output. Then, Christian suggested that I really should use `java --version`, which I promptly started using. However, `java --version`'s output is `java <version number>` and does not contain "java version" making the test fail. This combined with my forgetting to run testing before integration, lead to the backout.
Now, the last run of `java --version` that does not time out only checks that the exit code is 0, because I noticed that `java --version` might also output something else than "java" and checking for successful exit is sufficient to show that the test did not assert.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26882#issuecomment-3213768387
More information about the hotspot-compiler-dev
mailing list