RFR: 8365262: [IR-Framework] Add simple way to add cross-product of flags [v6]

Emanuel Peter epeter at openjdk.org
Fri Aug 22 14:10:55 UTC 2025


On Fri, 22 Aug 2025 14:06:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improvements prompted by Emanuel
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java line 53:
> 
>> 51:             TestFramework t = new TestFramework();
>> 52:             t.addCrossProductScenarios(null);
>> 53:             Asserts.fail("Should not have thrown exception");
> 
> Should or should not have thrown?

I think you copied it wrongly from elsewhere ;)
Not the only case, so check below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26762#discussion_r2293837521


More information about the hotspot-compiler-dev mailing list