RFR: 8364766: C2: Improve Value() of DivI and DivL for non-constant inputs [v4]
Tobias Hotz
duke at openjdk.org
Fri Aug 22 15:54:10 UTC 2025
> This PR improves the value of interger division nodes.
> Currently, we only emit a good type if either input is constant. But we can also cover the generic case. It does that by finding the four corners of the division. This is guranteed to find the extrema that we can use for min/max. Some special logic is required for MIN_INT / -1, though, as this is a special case
> We also need some special logic to handle ranges that cross zero, but in this case, we just need to check for the negative and positive range once.
> This also cleans up and unifies the code paths for DivINode and DivLNode.
> I've added some tests to validate the optimization. Without the changes, some of these tests fail.
Tobias Hotz has updated the pull request incrementally with one additional commit since the last revision:
Simplify the special case path
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26143/files
- new: https://git.openjdk.org/jdk/pull/26143/files/eef20ae6..4dc32af9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26143&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26143&range=02-03
Stats: 26 lines in 1 file changed: 1 ins; 8 del; 17 mod
Patch: https://git.openjdk.org/jdk/pull/26143.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26143/head:pull/26143
PR: https://git.openjdk.org/jdk/pull/26143
More information about the hotspot-compiler-dev
mailing list