RFR: 8365262: [IR-Framework] Add simple way to add cross-product of flags [v6]
Manuel Hässig
mhaessig at openjdk.org
Fri Aug 22 18:06:00 UTC 2025
On Fri, 22 Aug 2025 14:07:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java line 53:
>>
>>> 51: TestFramework t = new TestFramework();
>>> 52: t.addCrossProductScenarios(null);
>>> 53: Asserts.fail("Should not have thrown exception");
>>
>> Should or should not have thrown?
>
> I think you copied it wrongly from elsewhere ;)
> Not the only case, so check below.
Indeed copy paste without editing. Should be fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26762#discussion_r2294345338
More information about the hotspot-compiler-dev
mailing list