RFR: 8356813: Improve Mod(I|L)Node::Value [v6]

[Emanuel Peter]

On Mon, 25 Aug 2025 13:09:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hannes Greule has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
>> 
>>  - typos
>>  - Merge branch 'master' into improve-mod-value
>>  - Merge branch 'master' into improve-mod-value
>>  - simplify UB/cpu exception check
>>  - wording
>>  - Address more comments
>>  - Merge branch 'master' into improve-mod-value
>>  - Add randomized test
>>  - Use BasicType for shared implementation
>>  - Update ModL comment
>>  - ... and 8 more: https://git.openjdk.org/jdk/compare/9e98b6eb...11210414
>
> src/hotspot/share/opto/divnode.cpp line 1207:
> 
>> 1205:   const Type* t2 = phase->type(in2);
>> 1206:   if (t1 == Type::TOP) return Type::TOP;
>> 1207:   if (t2 == Type::TOP) return Type::TOP;
> 
> Suggestion:
> 
>   if (t1 == Type::TOP) { return Type::TOP; }
>   if (t2 == Type::TOP) { return Type::TOP; }
> 
> If we already touch the code, we should also fix the brackets.

Please fix it below as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25254#discussion_r2298064781