RFR: 8361582: AArch64: Some ConH values cannot be replicated with SVE [v7]

Bhavana Kilambi bkilambi at openjdk.org
Tue Aug 26 13:07:22 UTC 2025


On Thu, 21 Aug 2025 07:49:50 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 91:
> 
>> 89:             if (expected != output[i]) {
>> 90:                 throw new AssertionError("Result Mismatch!, input = " + input[i] + " constant = " + FP16_IN_RANGE + " actual = " + output[i] +  " expected = " + expected);
>> 91:             }
> 
> Prefer using Verify.check*
> https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/verify/Verify.java

Done

> test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java line 121:
> 
>> 119:             if (expected != output[i]) {
>> 120:                 throw new AssertionError("Result Mismatch!, input = " + input[i] + " constant = " + FP16_OUT_OF_RANGE + " actual = " + output[i] +  " expected = " + expected);
>> 121:             }
> 
> As above, please use Verify.check* API.

Done. thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2300923979
PR Review Comment: https://git.openjdk.org/jdk/pull/26589#discussion_r2300923665


More information about the hotspot-compiler-dev mailing list