RFR: 8365262: [IR-Framework] Add simple way to add cross-product of flags [v8]

[Manuel Hässig]

On Mon, 25 Aug 2025 15:16:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8365262
>>  - Remove excess newline
>>  - Fix indentation
>>  - Improve comments
>>  - Fix copy pasta mistakes
>>  - Improvements prompted by Emanuel
>>  - Fix test
>>  - Better counting in tests
>>  - post processing of flags and documentation
>>  - Make the test work
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/c1fb5caa...771924f0
>
> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 380:
> 
>> 378:             .reduce(
>> 379:                 Stream.of(Collections.<String>emptyList()), // Initialize Stream<List<String>> acc with a Stream containing an empty list of Strings.
>> 380:                 (acc, set) ->  // (Stream<List<String>>, Stream<List<String>>) -> Stream<List<String>>
> 
> You could probably put the types in the argument capture, no? Then it would become actual code.

Good point. This made me realize, I wrote down the wrong types...

> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 397:
> 
>> 395:                      .flatMap(Collection::stream) // Flatten the Stream<List<String>> into Stream<String>>.
>> 396:                      .filter(s -> !s.isEmpty()) // Remove empty string flags.
>> 397:                      .distinct()
> 
> Is this necessary? Could this reorder things? Sometimes order is relevant.

It is not. I removed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26762#discussion_r2300966957
PR Review Comment: https://git.openjdk.org/jdk/pull/26762#discussion_r2300967457