RFR: 8366357: C2 SuperWord: refactor VTransformNode::apply with VTransformApplyState [v3]
Emanuel Peter
epeter at openjdk.org
Thu Aug 28 13:55:03 UTC 2025
On Thu, 28 Aug 2025 13:39:44 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/vtransform.cpp line 737:
>>
>>> 735: // bits in a scalar shift operation. But vector shift does not truncate, so
>>> 736: // we must apply the mask now.
>>> 737: Node* shift_count_masked = new AndINode(shift_count_in, phase->igvn().intcon(_mask));
>>
>> Randomly noticed this: You should probably use `phase->intcon()` which also sets root as control`. Same at other places further down. You might want to squeeze that into this patch as well.
>
> Sure, I can do that. It probably does not matter because we set `major_progress` anyway... but better to do it :)
I'm doing it in a few SuperWord related places now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26987#discussion_r2307468339
More information about the hotspot-compiler-dev
mailing list