RFR: 8366357: C2 SuperWord: refactor VTransformNode::apply with VTransformApplyState [v3]

Manuel Hässig mhaessig at openjdk.org
Thu Aug 28 14:50:47 UTC 2025


On Thu, 28 Aug 2025 14:45:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/superword.cpp line 3072:
>> 
>>> 3070: 
>>> 3071:   // 1.1: con
>>> 3072:   Node* xbic = phase()->intcon(is_sub ? -con : con);
>> 
>> What changed that you need/want `PhaseIdealLoop*` here instead of `PhaseIterGVN*`?
>
> @chhagedorn Suggested it here: https://github.com/openjdk/jdk/pull/26987#discussion_r2307425745
> 
> That way, we set the control of the new constant. It was not strictly necessary, but good practice.

Makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26987#discussion_r2307654854


More information about the hotspot-compiler-dev mailing list