RFR: 8372703: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Dec 3 08:53:33 UTC 2025


On Tue, 2 Dec 2025 15:28:05 GMT, Volodymyr Paprotski <vpaprotski at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubDeclarations_x86.hpp line 76:
>> 
>>> 74:                                        do_arch_entry,                   \
>>> 75:                                        do_arch_entry_init)              \
>>> 76:   do_arch_blob(compiler, 120000 WINDOWS_ONLY(+2000))                    \
>> 
>> I was wondering if there are any reason for this value (apart that it is enough for the test to pass. I just noticed that it has been increased already in the past).
>
> The assert was suggesting 119k (and change..) so I rounded slightly up. I was going to ask (i.e. @TobiHartmann ?) if thats enough.. 
> 
> (Similarly, I am concerned that I am contributing to a larger JVM footprint, with my changes.. but I suppose 11k is comparatively insignificant in the grand scheme of things...)
> 
> Thanks for the review!

I think that's a reasonable increase.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28588#discussion_r2584174950


More information about the hotspot-compiler-dev mailing list