RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v10]

Galder Zamarreño galder at openjdk.org
Fri Dec 5 14:02:06 UTC 2025


On Fri, 5 Dec 2025 13:35:22 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 79 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8347273-verify-IGVN-Ideal-Identity
>>  - update comments for Christian
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - reorder flags for Christian
>>  - max_modes
>>  - use stringStream instead of ttyLocker
>>  - assert(false) for Christian
>>  - rename for Christian
>>  - Update src/hotspot/share/opto/phaseX.cpp
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - review suggestions, and handled a few more edge cases
>>  - ... and 69 more: https://git.openjdk.org/jdk/compare/968ce906...d9546d87
>
> src/hotspot/share/opto/phaseX.cpp line 1966:
> 
>> 1964:     //
>> 1965:     // Found with:
>> 1966:     //   compiler/codegen/TestBooleanVect.java
> 
> @eme64 Did you really encounter issues for this min/max codes with `TestBooleanVect`? Or is test name incorrect here?

Seems correct. I removed all the cases and indeed `TestBooleanVect` fails. All good :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2592791745


More information about the hotspot-compiler-dev mailing list