RFR: 8371920: [TEST] Enable CMove tests on other platforms [v2]

Fei Yang fyang at openjdk.org
Wed Dec 10 02:59:23 UTC 2025


On Tue, 9 Dec 2025 09:25:35 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> 
>> [JDK-8357551](https://bugs.openjdk.org/browse/JDK-8357551) add support of CMoveF/D vectorization, at the same time it also adds some tests for scalar CMove on riscv.
>> It's good to enable these tests on other platforms, like x86/aarch64 or maybe others.
>> 
>> At the same time, this pr also move these tests under `compiler/c2/cmove`, as suggested here https://github.com/openjdk/jdk/pull/28309#discussion_r2598664764.
>> 
>> Thanks!
>> 
>> ## Test
>> In progress... (I'm using github CI to run the tests.)
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   riscv + aarch64

test/hotspot/jtreg/compiler/c2/cmove/TestFPComparison2.java line 34:

> 32:  * @summary The test is to trigger code path of BoolTest::ge/gt in C2_MacroAssembler::enc_cmove_cmp_fp
> 33:  * @requires vm.debug
> 34:  * @requires os.arch == "riscv64" | os.arch=="aarch64"

One minor question: Could this work for `x64` as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28702#discussion_r2605010685


More information about the hotspot-compiler-dev mailing list