RFR: 8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis

[Roberto Castañeda Lozano]

On Tue, 9 Dec 2025 14:05:57 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> I just started some internal testing, will come back with results in a day or two, and hopefully also start reviewing this soon.

Test results look good except for trivial failures in product runs of the new tests, due to missing `-XX:+UnlockDiagnosticVMOptions` for the stress options.

> Right, this is what I propose to fix the present issue and it seems cleaner to me (we let `Identity` handle the identity transformations). I doubt there'll be a measurable compilation time difference. I don't have a strong opinion though, so we can go with what you propose as well. Let's see what other reviewers think before we make a decision!

Like Daniel and Damon, I also have a slight preference towards enqueuing the node and letting `PhiNode::Identity` perform the change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28677#issuecomment-3637196898