RFR: 8371920: [TEST] Enable CMove tests on other platforms [v2]
Emanuel Peter
epeter at openjdk.org
Wed Dec 10 14:04:52 UTC 2025
On Wed, 10 Dec 2025 13:32:42 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> I suppose adding `aarch64` is already a step in the right direction. But even better would be if we could remove the `@requires` completely, and just add restrictions to the `IR` rules.
>
> The first version of this pr did not have this `@requires`, but CI shows that IR verification failed, so I add this `@requires` for both riscv and aarch64 (check https://github.com/openjdk/jdk/pull/28702/commits/7848a1bf263ad9f498287f7b243601731b67b269)
> Yes, it's good to have it run on x86, but I think it's worth anothe pr to investigate it. How do you think about it?
I would remove the `@requires`, but add `applyIf` for the CPU features to the IR rules. Then we can still add more CPU features in a follow-up RFE, I don't want to force you to do more there 😊
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28702#discussion_r2606784829
More information about the hotspot-compiler-dev
mailing list