RFR: 8370922: Template Framework Library: Float16 type and operations [v3]
Benoît Maillard
bmaillard at openjdk.org
Mon Dec 15 08:31:55 UTC 2025
On Mon, 15 Dec 2025 06:58:52 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> It `Generate[s] expressions with any scalar numeric types.` ;)
>> The question is just how many per (output) type. Here we do 2 for each type.
>>
>> The 2 vs 10 is quite arbitrary. I did not want to increase the runtime of the test too much. For now, focusing more on the primitive types an operations is probably good, Float16 is still rather niche. But we can change the balance in the future.
>
> Ah yes, and note: even if we start with a type other than Float16 as the output, we can still have Float16 components in the expression, via conversion for example. We can do `float -> Float16 -> float` for example.
I meant to ask specificially about the inner loop sorry :)
The explanation makes sense, thanks for explaining a little more. Perhaps we could have a comment for that, or have constants with more explicit names for 2 and 10?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28095#discussion_r2618455025
More information about the hotspot-compiler-dev
mailing list