RFR: 8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis [v4]

[Emanuel Peter]

On Mon, 15 Dec 2025 14:05:32 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> And how confident are you that this one test ensures there won't be a regression?
>
> @eme64: My understanding of this issue is that it is really a case of nodes not being added properly to the IGVN worklist. What @rwestrel does is simply adding the missing entries to the worklist; he is not changing an existing optimization.

@dlunde @robcasloz  @rwestrel I leave this to you all. If you are very sure that the change is trivial, and that no additional IR tests are helpful, then leave it. But I've seen it happen multiple times that seemingly "trivial" changes have suddenly disabled older optimizations, and nobody noticed in the review. That's why I'm cautious in these cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28677#discussion_r2619608502