RFR: 8370200: Crash: assert(outer->outcnt() >= phis + 2 - be_loads && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis [v4]

[Roland Westrelin]

On Mon, 15 Dec 2025 15:01:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> @eme64 Right, always good to be cautious. In this case, the only thing we do is  `igvn->_worklist.push(u);`, which should be harmless and really only enable further optimizations. I'll let @rwestrel confirm!
>
>>  In this case, the only thing we do is igvn->_worklist.push(u);, which should be harmless and really only enable further optimizations.
> 
> If you are sure about that. I have not looked at it in depth. But what I see is also that code was moved from Identity to Ideal, and refactored.

Code was refactored but not moved. It is fairly similar to bugs fixed by adding logic to `PhaseIterGVN::add_users_of_use_to_worklist()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28677#discussion_r2619855092