RFR: 8373396: Min and Max Ideal missing AddNode::Ideal optimisations [v3]

Galder Zamarreño galder at openjdk.org
Tue Dec 16 07:53:53 UTC 2025


On Tue, 16 Dec 2025 07:37:45 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Remove MinI/MaxI exceptions from verify_Ideal_for"
>>   
>>   This reverts commit 1ae308155ebec12a9741eb40b1630dbde49af7ac.
>
> test/hotspot/jtreg/compiler/igvn/TestMinMaxIdeal.java line 101:
> 
>> 99:                 let("irNodeName", op.name()),
>> 100:                 let("boxedTypeName", op.type.boxedTypeName()),
>> 101:                 let("op", op.name()),
> 
> Nit: you are repeating the same value `op.name()` with two hashtags `op` and `irNodeName`. Is that intentional?

No, I'll get it fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28770#discussion_r2622182373


More information about the hotspot-compiler-dev mailing list