RFR: 8373355: C2: CompileCommand PrintIdealPhase should also print nodes that are not "reachable from below" [v2]

[Emanuel Peter]

On Tue, 16 Dec 2025 08:27:20 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRFindFromAbove.java
>>   
>>   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> Very fine!

@marc-chevalier @benoitmaillard @robcasloz Thanks for the reviews!

I'll need another approval because of the minor fix so I can integrate ;)

> test/hotspot/jtreg/compiler/c2/irTests/ModDNodeTests.java line 65:
> 
>> 63:     }
>> 64: 
>> 65:     // Note: we used to check for ConF nodes in the IR. But that is a bit brittle:
> 
> `ConD` in this case.

Nice catch!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28762#issuecomment-3659443105
PR Review Comment: https://git.openjdk.org/jdk/pull/28762#discussion_r2622338953