RFR: 8373343: C2: verify AddP base input only set for heap addresses

[Dean Long]

On Mon, 15 Dec 2025 15:14:57 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/memnode.cpp line 4126:
>> 
>>> 4124:     Node* base = dest;
>>> 4125:     if (phase->type(dest)->isa_oopptr() == nullptr) {
>>> 4126:       base = phase->C->top();
>> 
>> How is this possible?  Aren't all arrays in the heap?
>
> `isa_oopptr()` is non null for all oops, array and instance.

It seems like "dest" is always an oop here and we don't need to check isa_oopptr().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28769#discussion_r2625421249