Integrated: 8373396: Min and Max Ideal missing AddNode::Ideal optimisations

[Galder Zamarreño]

On Thu, 11 Dec 2025 16:02:24 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

> `MaxI` and `MinI` are missing `AddNode::Ideal` optimizations. These optimizations include commutation, flattening, pushing constants...etc. The PR changes `MaxINode::Ideal` and `MinINode::Ideal` to call `AddNode::Ideal`. Long versions already call `AddNode::Ideal` so nothing to change there.
> 
> The PR also includes a template framework generated test (cc @eme64) that verifies that all of `AddNode::Ideal` optimizations now apply correctly for min/max for longs and ints. Long tests have been added to validate that both ints and longs produce the same results.
> 
> Fixing this issue indirectly fixes `compiler/codegen/TestBooleanVect.java` when run with `-XX:VerifyIterativeGVN=1110`, which was failing due to `min` not having one of those optimisations. However, this PR does not make changes to `PhaseIterGVN::verify_Identity_for` because there are additional failures observed with min/max for integers in JDK-8373134. Therefore, changes there will in the PR for JDK-8373134 instead.
> 
> **Update 15.12.25**: `PhaseIterGVN::verify_Ideal_for` exceptions for MinI/MaxI are still needed.
> 
> ~If you look at `PhaseIterGVN::verify_Ideal_for`, it contains. This looks like it could be removed in this PR as it looks like they were quite likely disabled due to the issue here. However, it's unclear what test was failing here (@eme64 ?):~
> 
> 
>     // MinINode::Ideal
>     // Did not investigate, but there are some patterns that might
>     // need more notification.
>     case Op_MinI:
>     case Op_MaxI: // preemptively removed it as well.
>       return false;
> 
> 
> I've run tier1-3 tests on linux/x64 and they passed.

This pull request has now been integrated.

Changeset: 2c0d9a79
Author:    Galder Zamarreño <galder at openjdk.org>
Committer: Roland Westrelin <roland at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2c0d9a79b8197d88a104bd77026dd45b83a11f8a
Stats:     144 lines in 2 files changed: 144 ins; 0 del; 0 mod

8373396: Min and Max Ideal missing AddNode::Ideal optimisations

Reviewed-by: epeter, roland

-------------

PR: https://git.openjdk.org/jdk/pull/28770