RFR: 8371536: C2: VerifyIterativeGVN should assert on first detected failure [v6]

[Benoît Maillard]

On Fri, 14 Nov 2025 07:21:44 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Remove trailing whitespace
>>  - Merge branch 'master' into JDK-8371536
>>  - More style
>>  - Style and comments
>>  - Merge branch 'master' into JDK-8371536
>>  - Assert directly in the verify methods
>>  - Add comment for _table.hash_delete(n)
>>  - Change assert to print only the cause and the node name
>>    
>>    Bring back old comment
>>    
>>    Wording
>>  - Assert at first failure
>>  - Remove node from hash table before calling Ideal in verification
>
> @benoitmaillard Thanks for working on this, it will be really helpful for triaging :)

I have changed the code so that we assert directly in the verify methods, and merged with other changes that were carried out in the meantime. Let me know what you think @eme64 @chhagedorn.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28295#issuecomment-3670025367